PCI: apple: Do not leak reset GPIO on unbind/unload/error
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 6 Sep 2022 02:15:23 +0000 (19:15 -0700)
committerLorenzo Pieralisi <lpieralisi@kernel.org>
Wed, 14 Sep 2022 15:45:47 +0000 (17:45 +0200)
commita6b9ede1f3dfa5477791ad92d11f60f50998b689
tree2a2c7a35cd441f1ac1a80095a91b8b47028fd9ce
parent568035b01cfb107af8d2e4bd2fb9aea22cf5b868
PCI: apple: Do not leak reset GPIO on unbind/unload/error

The driver allocates reset GPIO in apple_pcie_setup_port() but neither
releases the resource, nor uses devm API to have it released
automatically.

Let's fix this by switching to devm API. While at it let's use generic
devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node()
- this will allow us top stop exporting the latter down the road.

Link: https://lore.kernel.org/r/YxatO5OaI2RpxQ2M@google.com
Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Hector Martin <marcan@marcan.st>
Acked-by: Marc Zyngier <maz@kernel.org>
drivers/pci/controller/pcie-apple.c