HID: hid-debug: clean up snprintf() checks in hid_resolv_usage()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 16 Sep 2021 13:21:54 +0000 (16:21 +0300)
committerJiri Kosina <jkosina@suse.cz>
Wed, 22 Sep 2021 09:49:17 +0000 (11:49 +0200)
commita68f3bd13994b315f47ec7e4da8d1c39ba0a2bb4
tree67d6803feceac1578b37d77849e024a114afe170
parentf3e8252124543836d3361e5c03909168077131a7
HID: hid-debug: clean up snprintf() checks in hid_resolv_usage()

The snprintf() limits are complicated and slightly wrong when it does:

max(0, HID_DEBUG_BUFSIZE - len - 1)

The "- 1" should not be there.  It means we can't use the last
byte of the buffer.  If we change the first snprintf() to scnprintf()
then we can remove the max().

At the start of the function the strlen(buf) is going always going to
be < HID_DEBUG_BUFSIZE so that is safe.  If it were > HID_DEBUG_BUFSIZE
then that would result in a WARN().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-debug.c