The breakpoint location hit counts were getting incremented in
authorJim Ingham <jingham@apple.com>
Wed, 22 Oct 2014 01:54:17 +0000 (01:54 +0000)
committerJim Ingham <jingham@apple.com>
Wed, 22 Oct 2014 01:54:17 +0000 (01:54 +0000)
commita672ecefef25bcc8cf0d7ac8d54c5139f6386df4
tree1f5d8d1c4d1dfdcb42e3f3370625b6a2e03b27e4
parent02306e1cdbf0df010dac241a973506f4e6ed23d5
The breakpoint location hit counts were getting incremented in
BreakpointLocation::ShouldStop.  That worked but wasn't really right,
since there's nothing to guarantee that won't get called more than
once.  So this change moves that responsibility to the StopInfoBreakpoint
directly, and then it uses the BreakpointSite to actually do the bumping.

Also fix a test case that was assuming if you had many threads running some
code with a breakpoint in it, the hit count when you stopped would always be
1.  Many of the threads could have hit it at the same time...

<rdar://problem/18577603>

llvm-svn: 220358
lldb/include/lldb/Breakpoint/BreakpointLocation.h
lldb/include/lldb/Breakpoint/BreakpointSite.h
lldb/source/Breakpoint/BreakpointLocation.cpp
lldb/source/Breakpoint/BreakpointLocationCollection.cpp
lldb/source/Breakpoint/BreakpointSite.cpp
lldb/source/Target/StopInfo.cpp
lldb/test/functionalities/attach_resume/TestAttachResume.py