dm: fix deadlock when swapping to encrypted device
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 10 Feb 2021 20:26:23 +0000 (15:26 -0500)
committerMike Snitzer <snitzer@redhat.com>
Thu, 11 Feb 2021 14:45:28 +0000 (09:45 -0500)
commita666e5c05e7c4aaabb2c5d58117b0946803d03d2
tree1a9dc24b70359cd4f268966d99763d79bea28926
parente3290b9491ff5b7ee40f9e0a4c06821988a2a2bf
dm: fix deadlock when swapping to encrypted device

The system would deadlock when swapping to a dm-crypt device. The reason
is that for each incoming write bio, dm-crypt allocates memory that holds
encrypted data. These excessive allocations exhaust all the memory and the
result is either deadlock or OOM trigger.

This patch limits the number of in-flight swap bios, so that the memory
consumed by dm-crypt is limited. The limit is enforced if the target set
the "limit_swap_bios" variable and if the bio has REQ_SWAP set.

Non-swap bios are not affected becuase taking the semaphore would cause
performance degradation.

This is similar to request-based drivers - they will also block when the
number of requests is over the limit.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-core.h
drivers/md/dm-crypt.c
drivers/md/dm.c
include/linux/device-mapper.h