mtd: cfi_cmdset_0020: Drop unnecessary static
authorJulia Lawall <julia.lawall@lip6.fr>
Thu, 4 May 2017 20:10:46 +0000 (22:10 +0200)
committerBrian Norris <computersforpeace@gmail.com>
Thu, 11 May 2017 18:49:20 +0000 (11:49 -0700)
commita63be500c6663a98cedda15c1bb380e9a34349e8
treea3897aa84669675a05f7932db9c4e3871abaac3f
parent5dc17fa6fb7063c6bc8ea9f3183ec19ca68bbfd6
mtd: cfi_cmdset_0020: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any use on every possible execution path through the function.  The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
  16671      48      16   16735    415f drivers/mtd/chips/cfi_cmdset_0020.o

after:
   text    data     bss     dec     hex filename
  16639      48       8   16695    4137 drivers/mtd/chips/cfi_cmdset_0020.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/chips/cfi_cmdset_0020.c