Fix racy output matching in gdb.base/cpcompletion.exp
authorPedro Alves <palves@redhat.com>
Thu, 9 Nov 2017 22:44:09 +0000 (22:44 +0000)
committerPedro Alves <palves@redhat.com>
Thu, 9 Nov 2017 22:46:06 +0000 (22:46 +0000)
commita60e07381c812ab82aff9abae203fd192f460ef4
tree1d28610586cfc9e3ea404593cb7ef36d8d1b98e8
parent2c88253fc469fbf40be7f0d1f7060b81055f2eb1
Fix racy output matching in gdb.base/cpcompletion.exp

With:

 $ make check-read1 TESTS="gdb.cp/cpcompletion.exp"

we get (from gdb.log):

 (gdb) complete break Foo::
 break Foo::Foo()
 break Foo::Foofoo()
 break Foo::get_foo()
 break Foo::set_foo(int)
 break Foo::~Foo()
 (gdb) FAIL: gdb.cp/cpcompletion.exp: complete class methods (Foo not found)

The problem is that the
  "break ${class}::\[A-Za-z0-9_~\]+"
regexp patches partial input, like:
  break Foo::F
  break Foo::Fo
  break Foo::Foo
etc.

Fix that by expecting each whole line.

gdb/testsuite/ChangeLog:
2017-11-09  Pedro Alves  <palves@redhat.com>

* gdb.cp/cpcompletion.exp (test_class_complete): Tighten regex to
match till end of line.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.cp/cpcompletion.exp