x86/sysfb: Fix check for bad VRAM size
authorArvind Sankar <nivedita@alum.mit.edu>
Tue, 7 Jan 2020 23:04:10 +0000 (18:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:21 +0000 (15:42 +0100)
commita5f30925cc192f129ef4ec777f24f87081c79dfd
tree0a12b1fa6497515c0228dd0f2694d040b7aadae7
parent0d9363214284382c42fac25162f2a8b68659ecb9
x86/sysfb: Fix check for bad VRAM size

[ Upstream commit dacc9092336be20b01642afe1a51720b31f60369 ]

When checking whether the reported lfb_size makes sense, the height
* stride result is page-aligned before seeing whether it exceeds the
reported size.

This doesn't work if height * stride is not an exact number of pages.
For example, as reported in the kernel bugzilla below, an 800x600x32 EFI
framebuffer gets skipped because of this.

Move the PAGE_ALIGN to after the check vs size.

Reported-by: Christopher Head <chead@chead.ca>
Tested-by: Christopher Head <chead@chead.ca>
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206051
Link: https://lkml.kernel.org/r/20200107230410.2291947-1-nivedita@alum.mit.edu
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/kernel/sysfb_simplefb.c