KVM: Fix race between APIC TMR and IRR
authorAvi Kivity <avi@redhat.com>
Tue, 29 Dec 2009 10:42:16 +0000 (12:42 +0200)
committerMarcelo Tosatti <mtosatti@redhat.com>
Mon, 25 Jan 2010 14:26:36 +0000 (12:26 -0200)
commita5d36f82c4f3e852b61fdf1fee13463c8aa91b90
tree5d7563cd69d710cf0948e48b26ff4b0cf197a51b
parentf6760aa024199cfbce564311dc4bc4d47b6fb349
KVM: Fix race between APIC TMR and IRR

When we queue an interrupt to the local apic, we set the IRR before the TMR.
The vcpu can pick up the IRR and inject the interrupt before setting the TMR,
and perhaps even EOI it, causing incorrect behaviour.

The race is really insignificant since it can only occur on the first
interrupt (usually following interrupts will not change TMR), but it's better
closed than open.

Fixed by reordering setting the TMR vs IRR.

Cc: stable@kernel.org
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
arch/x86/kvm/lapic.c