drm/i915/perf: Mark up the racy use of perf->exclusive_stream
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 27 Feb 2020 08:57:05 +0000 (08:57 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 28 Feb 2020 14:05:33 +0000 (14:05 +0000)
commita5af081d012e8b0ede5b1ef59a9c143067b45af6
tree520b3f037771a07abaf350e2455a2cdae3a45cf0
parent6875eb3ff5a37b73cd59bb6dcb6828ade1f62e66
drm/i915/perf: Mark up the racy use of perf->exclusive_stream

Inside the general i915_oa_init_reg_state() we avoid using the
perf->mutex. However, we rely on perf->exclusive_stream being valid to
access at that point, and for that we have to control the race with
disabling perf. This relies on the disabling being a heavy barrier that
inspects all active contexts, after marking the perf->exclusive_stream
as not available. This should ensure that there are no more concurrent
accesses to the perf->exclusive_stream as we destroy it.

Mark up the races around the perf->exclusive_stream so that they stand
out much more. (And hopefully we will be running kcsan to start
validating that the only races we have are carefully controlled.)

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200227085723.1961649-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_perf.c