rtw89: don't kick off TX DMA if failed to write skb
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 1 Dec 2021 09:38:16 +0000 (17:38 +0800)
committerKalle Valo <kvalo@kernel.org>
Wed, 8 Dec 2021 18:31:18 +0000 (20:31 +0200)
commita58fdb7c843a37d6598204c6513961feefdadc6a
tree333a0bbab801655ab38f7c6b19eb0711de9b47d4
parentc2258b29985eac9216a9e55f9d5bead9767f96da
rtw89: don't kick off TX DMA if failed to write skb

This is found by Smatch static checker warning:
drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
error: uninitialized symbol 'qsel'.

The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to
failed to write. The way to fix it is to avoid kicking off TX DMA, so add
'return' to the failure case.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211201093816.13806-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/mac80211.c