ir3: Don't save/restore disasm string pointer
authorConnor Abbott <cwabbott0@gmail.com>
Tue, 29 Nov 2022 13:30:00 +0000 (14:30 +0100)
committerEric Engestrom <eric@engestrom.ch>
Wed, 30 Nov 2022 21:12:44 +0000 (21:12 +0000)
commita584116950215e042c1e7c7ee20eda07eb4e5fae
tree95599259156ab7ff4c7b7479e006463f6082aaf9
parentd28350a810797ea98f495b7ca6918b720acfa439
ir3: Don't save/restore disasm string pointer

It's not in the key, so it randomly may or may not be present, and if it
is present then we don't actually save/restore the contents, so we will
save/restore random pointer values from the last run. Turnip already
disables searching the shader cache when assembly is requested, but
still wrote the final ir3_shader_variant which resulted in trying to
save random stale pointers when saving off the executable if a
subsequent compile hit that cache entry.

This fixes flakes in
dEQP-VK.pipeline.pipeline_library.shader_module_identifier.pipeline_from_id.*
for me.

Fixes: 56909868cd1 ("turnip: implement VK_KHR_pipeline_executable_properties")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20056>
(cherry picked from commit 8ba2d612d51497b274ff9c4213e1c373b9bb1ca5)
.pick_status.json
src/freedreno/ir3/ir3_shader.h