ath9k: fix ath_tx_process_buffer() potential null ptr dereference
authorShuah Khan <skhan@linuxfoundation.org>
Sat, 13 Feb 2021 05:58:47 +0000 (07:58 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 16 Feb 2021 07:02:34 +0000 (09:02 +0200)
commita56c14bb21b296fb6d395164ab62ef2e419e5069
tree4e30670681804a19cbd8e647b7b625751777261c
parent773dc50d71690202afd7b5017c060c6ca8c75dd9
ath9k: fix ath_tx_process_buffer() potential null ptr dereference

ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr()
return pointer (sta) outside null check. Fix it by moving the code
block under the null check.

This problem was found while reviewing code to debug RCU warn from
ath10k_wmi_tlv_parse_peer_stats_info() and a subsequent manual audit
of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
RCU read lock.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/43ed9abb9e8d7112f3cc168c2f8c489e253635ba.1613090339.git.skhan@linuxfoundation.org
drivers/net/wireless/ath/ath9k/xmit.c