tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()
authorJarkko Sakkinen <jarkko@kernel.org>
Fri, 19 Feb 2021 22:55:59 +0000 (00:55 +0200)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 24 Feb 2021 16:53:22 +0000 (18:53 +0200)
commita5665ec2affdba21bff3b0d4d3aed83b3951e8ff
tree587214574562dd8c303345d756891792cee3ce1a
parentc03c21ba6f4e95e406a1a7b4c34ef334b977c194
tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()

This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
(SLB 9670):

[    4.324298] TPM returned invalid status
[    4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f

Background
==========

TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
Interface Locality Usage per Register, Table 39 Register Behavior Based on
Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
0xFF in case of lack of locality.

The fix
=======

Decorate tpm_get_timeouts() with request_locality() and release_locality().

Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Laurent Bigonville <bigon@debian.org>
Cc: stable@vger.kernel.org
Reported-by: Lukasz Majczak <lma@semihalf.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_core.c