discoverer: Prevent stream tags from leaking in global tags
authorPhilippe Normand <philn@igalia.com>
Sun, 12 Sep 2021 09:07:49 +0000 (10:07 +0100)
committerPhilippe Normand <philn@igalia.com>
Sun, 12 Sep 2021 09:20:05 +0000 (10:20 +0100)
commita55dafe341ac7398e7c37c30d8b760228296da92
treefe4cf74ef22e00b686be25411c7e8329e4fb4d0a
parentf6aea043f93729db41187e19574bb1d1b96587db
discoverer: Prevent stream tags from leaking in global tags

The PrivateStream should keep track of stream tags only. Likewise, the
GstDiscovererInfo should keep track of global tags only.

This patch fixes the issue where the discoverer would report duplicated tag
titles, especially for Matroska media files. The Matroska demuxer emits
correctly-scoped tags, but downstream was making no distinction of them.

Fixes #598, #836, https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/827

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1275>
gst-libs/gst/pbutils/gstdiscoverer.c