jfs: prevent NULL deref in diFree
authorHaimin Zhang <tcs_kernel@tencent.com>
Tue, 22 Mar 2022 13:59:17 +0000 (21:59 +0800)
committerDave Kleikamp <dave.kleikamp@oracle.com>
Tue, 22 Mar 2022 15:09:19 +0000 (10:09 -0500)
commita53046291020ec41e09181396c1e829287b48d47
tree75c5fe996ec52f270cb196cf41c8f6756cf80b3c
parent2cc7cc01c15f57d056318c33705647f87dcd4aab
jfs: prevent NULL deref in diFree

Add validation check for JFS_IP(ipimap)->i_imap to prevent a NULL deref
in diFree since diFree uses it without do any validations.
When function jfs_mount calls diMount to initialize fileset inode
allocation map, it can fail and JFS_IP(ipimap)->i_imap won't be
initialized. Then it calls diFreeSpecial to close fileset inode allocation
map inode and it will flow into jfs_evict_inode. Function jfs_evict_inode
just validates JFS_SBI(inode->i_sb)->ipimap, then calls diFree. diFree use
JFS_IP(ipimap)->i_imap directly, then it will cause a NULL deref.

Reported-by: TCS Robot <tcs_robot@tencent.com>
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
fs/jfs/inode.c