perf/core: Fix crash due to account/unaccount_sb_event() inconsistency
authorDavid Carrillo-Cisneros <davidcc@google.com>
Wed, 1 Jun 2016 19:33:05 +0000 (12:33 -0700)
committerIngo Molnar <mingo@kernel.org>
Wed, 8 Jun 2016 07:18:45 +0000 (09:18 +0200)
commita4f144ebbdf6f7807c477bce8e136047ed27321f
tree93fbb633948b9c6e47c52fe7b2eab07d351ee50d
parent030ba6cd105c68ce919c5e239853b567490cd059
perf/core: Fix crash due to account/unaccount_sb_event() inconsistency

unaccount_pmu_sb_event() did not check for attributes in event->attr
before calling detach_sb_event(), while account_pmu_event() did.

This caused NULL pointer reference in cgroup events that did not
have any of the attributes checked by account_pmu_event().

To trigger the bug just wait for a cgroup event to terminate, e.g.:

  $ mkdir /dev/cgroup/devices/test
  $ perf stat -e cycles -a -G test sleep 0

... see crash ...

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Reviewed-by: Stephane Eranian <eranian@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Zheng <zheng.z.yan@intel.com>
Link: http://lkml.kernel.org/r/1464809585-66072-1-git-send-email-davidcc@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/core.c