pxa: Drop if with an always false condition
authorUwe Kleine-König <(address hidden)>
Mon, 26 Sep 2022 10:40:11 +0000 (12:40 +0200)
committerArnd Bergmann <arnd@arndb.de>
Mon, 26 Sep 2022 10:40:11 +0000 (12:40 +0200)
commita4d1846512e12f9e84be63b3f2f2165e4d0d2d1e
tree4e6331f9d50d745a1d3567bed92aa084d7bfc076
parent63872304bdb3decd5454f4dd210c25395278ed13
pxa: Drop if with an always false condition

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so ssp is never NULL.

Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm
callbacks are called. So the memory that ssp pointed to during probe,
goes away without the node being removed from ssp_list. The probable
result of an early exit is accessing freed memory when the list is
walked the next time.

Signed-off-by: Uwe Kleine-König <(address hidden)>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/soc/pxa/ssp.c