selftests/bpf: Fix error reporting from sock_fields programs
authorJakub Sitnicki <jakub@cloudflare.com>
Thu, 17 Mar 2022 11:39:17 +0000 (12:39 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 18 Mar 2022 14:46:58 +0000 (15:46 +0100)
commita4c9fe0ed4a13e25e43fcd44d9f89bc19ba8fbb7
tree60883aef0a2edaef2520082e5b6506883afe5e49
parent60911970b0163f28495d4d3d669d8f5803df8cf1
selftests/bpf: Fix error reporting from sock_fields programs

The helper macro that records an error in BPF programs that exercise sock
fields access has been inadvertently broken by adaptation work that
happened in commit b18c1f0aa477 ("bpf: selftest: Adapt sock_fields test to
use skel and global variables").

BPF_NOEXIST flag cannot be used to update BPF_MAP_TYPE_ARRAY. The operation
always fails with -EEXIST, which in turn means the error never gets
recorded, and the checks for errors always pass.

Revert the change in update flags.

Fixes: b18c1f0aa477 ("bpf: selftest: Adapt sock_fields test to use skel and global variables")
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20220317113920.1068535-2-jakub@cloudflare.com
tools/testing/selftests/bpf/progs/test_sock_fields.c