tipc: fix shutdown() of connection oriented socket
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sat, 5 Sep 2020 06:14:47 +0000 (15:14 +0900)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Sep 2020 19:21:39 +0000 (12:21 -0700)
commita4b5cc9e10803ecba64a7d54c0f47e4564b4a980
treed622d74128bbd4061c4beac5ab87457e86492920
parent46cf789b68b25744be3dc99efd4afce4a5381b5c
tipc: fix shutdown() of connection oriented socket

I confirmed that the problem fixed by commit 2a63866c8b51a3f7 ("tipc: fix
shutdown() of connectionless socket") also applies to stream socket.

----------
#include <sys/socket.h>
#include <unistd.h>
#include <sys/wait.h>

int main(int argc, char *argv[])
{
        int fds[2] = { -1, -1 };
        socketpair(PF_TIPC, SOCK_STREAM /* or SOCK_DGRAM */, 0, fds);
        if (fork() == 0)
                _exit(read(fds[0], NULL, 1));
        shutdown(fds[0], SHUT_RDWR); /* This must make read() return. */
        wait(NULL); /* To be woken up by _exit(). */
        return 0;
}
----------

Since shutdown(SHUT_RDWR) should affect all processes sharing that socket,
unconditionally setting sk->sk_shutdown to SHUTDOWN_MASK will be the right
behavior.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c