fbmem: add margin check to fb_check_caps()
authorGeorge Kennedy <george.kennedy@oracle.com>
Tue, 7 Jul 2020 19:26:03 +0000 (15:26 -0400)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 8 Sep 2020 11:33:01 +0000 (13:33 +0200)
commita49145acfb975d921464b84fe00279f99827d816
treefc4f2b412cc723119d7b77c0dc0fcbed1701b68f
parent54d04ea8cdbd143496e4f5cc9c0a9f86c0e55a2e
fbmem: add margin check to fb_check_caps()

A fb_ioctl() FBIOPUT_VSCREENINFO call with invalid xres setting
or yres setting in struct fb_var_screeninfo will result in a
KASAN: vmalloc-out-of-bounds failure in bitfill_aligned() as
the margins are being cleared. The margins are cleared in
chunks and if the xres setting or yres setting is a value of
zero upto the chunk size, the failure will occur.

Add a margin check to validate xres and yres settings.

Signed-off-by: George Kennedy <george.kennedy@oracle.com>
Reported-by: syzbot+e5fd3e65515b48c02a30@syzkaller.appspotmail.com
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dhaval Giani <dhaval.giani@oracle.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1594149963-13801-1-git-send-email-george.kennedy@oracle.com
drivers/video/fbdev/core/fbmem.c