drm/i915/gt: Wait for new requests in intel_gt_retire_requests()
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 14 Nov 2019 22:57:32 +0000 (22:57 +0000)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 18 Nov 2019 14:36:39 +0000 (16:36 +0200)
commita46bfdc83fee0a83aae54390729df12abce57f45
treef9196faa883ac0f3d5fbc05c9e070fcf4f2dbebf
parent2a39b072ee6990512ff0829a4eba5b409dff2746
drm/i915/gt: Wait for new requests in intel_gt_retire_requests()

Our callers fall into two categories, those passing timeout=0 who just
want to flush request retirements and those passing a timeout that need
to wait for submission completion (e.g. intel_gt_wait_for_idle()).
Currently, we only wait for a snapshot of timelines at the start of the
wait (but there was an expectation that new requests would cause timelines
to appear at the end). However, our callers, such as
intel_gt_wait_for_idle() before suspend, do require us to wait for the
power management requests emitted by retirement as well. If we don't,
then it takes an extra second or two for the background worker to flush
the queue and mark the GT as idle.

Fixes: 7e8057626640 ("drm/i915: Drop struct_mutex from around i915_retire_requests()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191114225736.616885-1-chris@chris-wilson.co.uk
(cherry picked from commit 7936a22dd4660d24b4ca0668c02b0372127cab44)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/gt/intel_gt_requests.c