power: supply: axp20x_usb_power: Drop unnecessary static
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 4 May 2017 20:10:49 +0000 (22:10 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 15 May 2017 13:28:14 +0000 (15:28 +0200)
commita463182031c122f91ccebc14f743654f12aa9cec
tree374a8355c531c84f115b179f99c04cfb001021bf
parentc94d4ed017ae6e2630647b917e775ab2fd8ea0f3
power: supply: axp20x_usb_power: Drop unnecessary static

Drop static on a local variable, when the variable is either first
initialized or never used, on every possible execution path through the
function.  The static has no benefit, and dropping it reduces the code
size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
   2865     252       8    3125     c35 drivers/power/supply/axp20x_usb_power.o

after:
   text    data     bss     dec     hex filename
   2822     252       0    3074     c02 drivers/power/supply/axp20x_usb_power.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/axp20x_usb_power.c