coresight: etm4x: Ensure valid drvdata and clock before clk_put()
authorAnshuman Khandual <anshuman.khandual@arm.com>
Thu, 17 Aug 2023 03:59:26 +0000 (09:29 +0530)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 17 Aug 2023 10:49:21 +0000 (11:49 +0100)
commita4621fd1d4fd04fe2d8105a4d64e85cdc4a259b1
treeb9fe3ca2a78d91e8b928392b90101f095bb005d9
parent39744738a67de9153d73e11817937c0004feab2e
coresight: etm4x: Ensure valid drvdata and clock before clk_put()

This validates 'drvdata' and 'drvdata->pclk' clock before calling clk_put()
in etm4_remove_platform_dev(). The problem was detected using Smatch static
checker as reported.

Fixes: 73d779a03a76a ("coresight: etm4x: Change etm4_platform_driver driver for MMIO devices")
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: James Clark <james.clark@arm.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lists.linaro.org/archives/list/coresight@lists.linaro.org/thread/G4N6P4OXELPLLQSNU3GU2MR4LOLRXRMJ/
Reviewed-by: James Clark <james.clark@arm.com>
Reviewed-by: Mike Leach <mike.leach@lnaro.org>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230817035926.157370-1-anshuman.khandual@arm.com
drivers/hwtracing/coresight/coresight-etm4x-core.c