Add virtual destructors to two classes with other virtuals
authorThiago Macieira <thiago.macieira@intel.com>
Fri, 25 Jan 2013 21:39:28 +0000 (13:39 -0800)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Fri, 25 Jan 2013 21:48:56 +0000 (22:48 +0100)
commita45d35c07f9eed27fc286ab5fbc00789d45259b5
tree46cd28b8d77279055e7eecbd11777e946f5356f1
parent35393a6469a5d886c415e947be788b206c7ea76d
Add virtual destructors to two classes with other virtuals

Classes with virtuals are used polymorphically (why have virtuals
otherwise?), so they need virtual destructors to be deleted
properly. Unless they are never deleted using objects of those two
classes -- but why have the interface in the first place if that's the
case?

This is binary incompatible change. It was agreed upon in the mailing
list.

Change-Id: I697e4bd53251452a0e6b0c09edd08c4835f90cbd
Discussed-on: http://lists.qt-project.org/pipermail/development/2012-December/008908.html
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
src/multimedia/audio/qaudiosystemplugin.cpp
src/multimedia/audio/qaudiosystemplugin.h
src/multimedia/qmediaserviceprovider.cpp
src/multimedia/qmediaserviceproviderplugin.h