bus: sunxi-rsb: Return correct data when mixing 16-bit and 8-bit reads
authorOndrej Jirman <megous@megous.com>
Fri, 21 Feb 2020 20:27:26 +0000 (21:27 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 24 Feb 2020 11:02:38 +0000 (12:02 +0100)
commita43ab30dcd4a1abcdd0d2461bf1cf7c0817f6cd3
tree3134b5c4c3753d90084ce9448050747d83c3e2c8
parentb642d4825441bf30c72b72deb739bd2d5f53af08
bus: sunxi-rsb: Return correct data when mixing 16-bit and 8-bit reads

When doing a 16-bit read that returns data in the MSB byte, the
RSB_DATA register will keep the MSB byte unchanged when doing
the following 8-bit read. sunxi_rsb_read() will then return
a result that contains high byte from 16-bit read mixed with
the 8-bit result.

The consequence is that after this happens the PMIC's regmap will
look like this: (0x33 is the high byte from the 16-bit read)

% cat /sys/kernel/debug/regmap/sunxi-rsb-3a3/registers
00: 33
01: 33
02: 33
03: 33
04: 33
05: 33
06: 33
07: 33
08: 33
09: 33
0a: 33
0b: 33
0c: 33
0d: 33
0e: 33
[snip]

Fix this by masking the result of the read with the correct mask
based on the size of the read. There are no 16-bit users in the
mainline kernel, so this doesn't need to get into the stable tree.

Signed-off-by: Ondrej Jirman <megous@megous.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/bus/sunxi-rsb.c