Refactor sigcontextinfo.h
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 17 Dec 2018 18:44:14 +0000 (16:44 -0200)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Fri, 23 Aug 2019 14:30:56 +0000 (11:30 -0300)
commita43565ac447b1608ae2626f5012673560bb623ab
treec759caab740e9ab6ed830edcef55b33f06ec665c
parent624c109b2a273dbfd6f87795a64ac1f6c5d89f10
Refactor sigcontextinfo.h

This patch refactor sigcontextinfo.h header to use SA_SIGINFO as default
for both gmon and debug implementations.  This allows simplify
profil-counter.h on Linux to use a single implementation and remove the
requirements for newer ports to redefine __sigaction/sigaction to use
SA_SIGINFO.

The GET_PC macro is also replaced with a function sigcontext_get_pc that
returns an uintptr_t instead of a void pointer.  It allows easier convertion
to integer on ILP32 architecture, such as x32, without the need to suppress
compiler warnings.

The patch also requires some refactor of register-dump.h file for some
architectures (to reflect it is now called from a sa_sigaction instead of
sa_handler signal context).

   - Alpha, i386, and s390 are straighfoward to take in consideration the
     new argument type.

   - ia64 takes in consideration the kernel pass a struct sigcontextt
     as third argument for sa_sigaction.

   - sparc take in consideration the kernel pass a pt_regs struct
     as third argument for sa_sigaction.

   - m68k dummy function is removed and the FP state is dumped on
     register_dump itself.

   - For SH the register-dump.h file is consolidate on a common implementation
     and the floating-point state is checked based on ownedfp field.

The register_dump does not change its output format in any affected
architecture.

I checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu,
arm-linux-gnueabihf, sparcv9-linux-gnu, sparc64-linux-gnu, powerpc-linux-gnu,
powerpc64-linux-gnu, and powerpc64le-linux-gnu.

I also checked the libSegFault.so through catchsegv on alpha-linux-gnu,
m68k-linux-gnu and sh4-linux-gnu to confirm the output has not changed.

Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Florian Weimer  <fweimer@redhat.com>

* debug/segfault.c (install_handler): Use SA_SIGINFO if defined.
* sysdeps/generic/profil-counter.h (__profil_counter): Cast to
uintptr_t.
* sysdeps/generic/sigcontextinfo.h (GET_PC): Rename to
sigcontext_get_pc and return aligned cast to uintptr_t.
* sysdeps/mach/hurd/i386/sigcontextinfo.h (GET_PC): Likewise.
* sysdeps/posix/profil.c (profil_count): Change PC argument to
uintptr_t.
(__profil): Use SA_SIGINFO.
* sysdeps/posix/sprofil.c (profil_count): Change PCP argument to
uintptr_t.
(__sprofil): Use SA_SIGINFO.
* sysdeps/unix/sysv/linux/profil-counter.h: New file.
* sysdeps/unix/sysv/linux/aarch64/profil-counter.h: Remove file.
* sysdeps/unix/sysv/linux/csky/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/hppa/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/i386/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/ia64/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/microblaze/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/mips/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/nios2/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/powerpc/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/x86_64/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/riscv/profil-counter.h: Likewise.
* sysdeps/sysv/linux/s390/s390-32/profil-counter.h: Likewise.
* sysdeps/sysv/linux/s390/s390-64/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/sh/profil-counter.h: Likewise.
* sysdeps/unix/sysv/linux/arm/profil-counter.h (__profil_counter):
Assume SA_SIGINFO and use sigcontext_get_pc instead of GET_PC.
* sysdeps/unix/sysv/linux/sparc/profil-counter.h: New file.
* sysdeps/unix/sysv/linux/sparc/sparc64/profil-counter.h: Remove file.
* sysdeps/unix/sysv/linux/sparc/sparc32/profil-counter.h: Likewise.
* sysdpes/unix/sysv/linux/aarch64/sigcontextinfo.h (SIGCONTEXT,
GET_PC, __sigaction, sigaction): Remove defines.
(sigcontext_get_pc): New function.
* sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/arm/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/csky/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/hppa/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/i386/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/ia64/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/m68k/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/mips/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/nios2/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/s390/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/powerpc/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/riscv/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/sh/sigcontextinfo.h: Likewise.
* sysdeps/sysv/linux/sparc/sparc32/sigcontextinfo.h: Likewise.
* sysdeps/sysv/linux/sparc/sparc64/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/x86_64/sigcontextinfo.h: Likewise.
* sysdeps/unix/sysv/linux/alpha/register-dump.h (register_dump):
Handle CTX argument as ucontext_t.
* sysdeps/unix/sysv/linux/i386/register-dump.h: Likewise.
Likewise.
* sysdeps/unix/sysv/linux/m68k/register-dump.h: Likewise.
* sysdeps/sysv/linux/s390/s390-32/register-dump.h: Likewise.
* sysdeps/sysv/linux/s390/s390-64/register-dump.h: Likewise.
* sysdeps/unix/sysv/linux/sh/register-dump.h: New file.
* sysdeps/unix/sysv/linux/sh/sh4/register-dump.h: Remove File.
* sysdeps/unix/sysv/linux/sh/sh3/register-dump.h: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/register-dump.h: Likewise.
* sysdeps/unix/sysv/linux/Makefile (tests-internal): Add
tst-sigcontextinfo-get_pc.
* sysdeps/unix/sysv/linux/tst-sigcontextinfo-get_pc.c: New file.
(CFLAGS-tst-sigcontextinfo-get_pc.c): New rule.
52 files changed:
ChangeLog
debug/segfault.c
sysdeps/generic/profil-counter.h
sysdeps/generic/sigcontextinfo.h
sysdeps/mach/hurd/i386/sigcontextinfo.h
sysdeps/posix/profil.c
sysdeps/posix/sprofil.c
sysdeps/unix/sysv/linux/Makefile
sysdeps/unix/sysv/linux/aarch64/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/aarch64/sigcontextinfo.h
sysdeps/unix/sysv/linux/alpha/register-dump.h
sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h
sysdeps/unix/sysv/linux/arm/profil-counter.h
sysdeps/unix/sysv/linux/arm/sigcontextinfo.h
sysdeps/unix/sysv/linux/csky/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/csky/sigcontextinfo.h
sysdeps/unix/sysv/linux/hppa/sigcontextinfo.h [moved from sysdeps/unix/sysv/linux/hppa/profil-counter.h with 76% similarity]
sysdeps/unix/sysv/linux/i386/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/i386/register-dump.h
sysdeps/unix/sysv/linux/i386/sigcontextinfo.h
sysdeps/unix/sysv/linux/ia64/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/ia64/sigcontextinfo.h
sysdeps/unix/sysv/linux/m68k/register-dump.h
sysdeps/unix/sysv/linux/m68k/sigcontextinfo.h
sysdeps/unix/sysv/linux/microblaze/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h
sysdeps/unix/sysv/linux/mips/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/mips/sigcontextinfo.h
sysdeps/unix/sysv/linux/nios2/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/nios2/sigcontextinfo.h
sysdeps/unix/sysv/linux/powerpc/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/powerpc/sigcontextinfo.h
sysdeps/unix/sysv/linux/profil-counter.h [moved from sysdeps/unix/sysv/linux/x86_64/profil-counter.h with 66% similarity]
sysdeps/unix/sysv/linux/riscv/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/riscv/sigcontextinfo.h
sysdeps/unix/sysv/linux/s390/s390-32/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/s390/s390-32/register-dump.h
sysdeps/unix/sysv/linux/s390/s390-64/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/s390/s390-64/register-dump.h
sysdeps/unix/sysv/linux/s390/sigcontextinfo.h
sysdeps/unix/sysv/linux/sh/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/sh/register-dump.h [moved from sysdeps/unix/sysv/linux/sh/sh4/register-dump.h with 62% similarity]
sysdeps/unix/sysv/linux/sh/sh3/register-dump.h [deleted file]
sysdeps/unix/sysv/linux/sh/sigcontextinfo.h
sysdeps/unix/sysv/linux/sparc/profil-counter.h [moved from sysdeps/unix/sysv/linux/sparc/sparc64/profil-counter.h with 77% similarity]
sysdeps/unix/sysv/linux/sparc/sparc32/profil-counter.h [deleted file]
sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h
sysdeps/unix/sysv/linux/sparc/sparc32/sigcontextinfo.h
sysdeps/unix/sysv/linux/sparc/sparc64/register-dump.h
sysdeps/unix/sysv/linux/sparc/sparc64/sigcontextinfo.h
sysdeps/unix/sysv/linux/tst-sigcontext-get_pc.c [new file with mode: 0644]
sysdeps/unix/sysv/linux/x86_64/sigcontextinfo.h