sk_buff: avoid potentially clearing 'slow_gro' field
authorPaolo Abeni <pabeni@redhat.com>
Fri, 30 Jul 2021 16:30:53 +0000 (18:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 30 Jul 2021 18:48:06 +0000 (20:48 +0200)
commita432934a30679c0e3c47b87f13e4901bc1a3fc03
treed293615b1dda88bd355e0d0e44038b003e3074d8
parentbc830525615df6b6b1793ac23750f32695903fd0
sk_buff: avoid potentially clearing 'slow_gro' field

If skb_dst_set_noref() is invoked with a NULL dst, the 'slow_gro'
field is cleared, too. That could lead to wrong behavior if
the skb later enters the GRO stage.

Fix the potential issue replacing preserving a non-zero value of
the 'slow_gro' field.

Additionally, fix a comment typo.

Reported-by: Sabrina Dubroca <sd@queasysnail.net>
Reported-by: Jakub Kicinski <kuba@kernel.org>
Fixes: 8a886b142bd0 ("sk_buff: track dst status in slow_gro")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/aa42529252dc8bb02bd42e8629427040d1058537.1627662501.git.pabeni@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/skbuff.h
net/core/dev.c