Bluetooth: Depend on rather than select GPIOLIB
authorLukas Wunner <lukas@wunner.de>
Tue, 2 Jan 2018 19:08:40 +0000 (20:08 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 8 Jan 2018 20:44:22 +0000 (21:44 +0100)
commita3a446c7c0e643f740990a7bc2950e75856beb3c
treeea96496b945e121cf7f25d7016f8475be187e3b0
parentb71b25fed1c3fa7fdeba4bbda2d17fb384a80508
Bluetooth: Depend on rather than select GPIOLIB

Commit 27378f4c1b92 ("Bluetooth: Avoid WARN splat due to missing
GPIOLIB") amended Kconfig to select GPIOLIB if BT_HCIUART_NOKIA,
BT_HCIUART_INTEL or BT_HCIUART_BCM is enabled since all three drivers
require it to function.

The diagnosis was correct but the treatment was not.  As stated in
Documentation/gpio/consumer.txt:

    Guidelines for GPIOs consumers
    ==============================

    Drivers that can't work without standard GPIO calls should have
    Kconfig entries that depend on GPIOLIB.
                         ^^^^^^^^^
Fix it.

Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/Kconfig