VK_EXT_pipeline_creation_feedback: Invalid feedback is legal
authorChad Versace <chadversary@google.com>
Thu, 25 Aug 2022 20:27:53 +0000 (13:27 -0700)
committerMatthew Netsch <quic_mnetsch@quicinc.com>
Thu, 8 Sep 2022 16:36:11 +0000 (16:36 +0000)
commita393bf2c856db87731376677600c8caa2959eb94
tree7a02b862f8bc839c93311a8ea111ddca844ac066
parentb72e4fba869b8fc722ae2bc9407c5463ae3b00c0
VK_EXT_pipeline_creation_feedback: Invalid feedback is legal

The tests incorrectly required that
VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT be set in
VkPipelineCreationFeedbackCreateInfo::pPipelineCreationFeedback.
However, the tests already and correctly permit the bit to be unset in
VkPipelineCreationFeedbackCreateInfo::pPipelineStageCreationFeedbacks.

The Vulkan 1.3.225 spec says:
    An implementation should write pipeline creation feedback to
    pPipelineCreationFeedback and may write pipeline stage creation
    feedback to pPipelineStageCreationFeedbacks. An implementation must
    set or clear the VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT in
    VkPipelineCreationFeedback::flags for pPipelineCreationFeedback and
    every element of pPipelineStageCreationFeedbacks.

Components: Vulkan
VK-GL-CTS Issue: 3912
Affects:
dEQP-VK.pipeline.creation_feedback.*

Signed-off-by: Chad Versace <chadversary@google.com>
Change-Id: I4eb37b5888a4d780b4b0b12f9c65960aca9f7806
external/vulkancts/modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp