platform/x86: intel-hid: Fix spurious wakeups caused by tablet-mode events during...
authorHans de Goede <hdegoede@redhat.com>
Sun, 4 Apr 2021 14:38:31 +0000 (16:38 +0200)
committerHans de Goede <hdegoede@redhat.com>
Tue, 6 Apr 2021 20:10:21 +0000 (22:10 +0200)
commita3790a8a94fc0234c5d38013b48e74ef221ec84c
tree169d93e81bdbe0891b330226e25e4d62be8bb524
parentd1635448f1105e549b4041aab930dbc6945fc635
platform/x86: intel-hid: Fix spurious wakeups caused by tablet-mode events during suspend

Some devices send (duplicate) tablet-mode events when moved around even
though the mode has not changed; and they do this even when suspended.

Change the tablet-mode event handling when priv->wakeup_mode is set to
update the switch state in case it changed and then return immediately
(without calling pm_wakeup_hard_event()) to avoid spurious wakeups.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212537
Fixes: 537b0dd4729e ("platform/x86: intel-hid: Add support for SW_TABLET_MODE")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Elia Devito <eliadevito@gmail.com>
Link: https://lore.kernel.org/r/20210404143831.25173-1-hdegoede@redhat.com
drivers/platform/x86/intel-hid.c