[SCSI] scsi_debug: Fix 32-bit overflow in do_device_access causing memory corruption
authorDarrick J. Wong <djwong@us.ibm.com>
Tue, 1 Feb 2011 02:47:54 +0000 (18:47 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Sat, 12 Feb 2011 17:21:56 +0000 (11:21 -0600)
commita361cc0025614fdd07f5f69aeeaa8075530870bc
tree419b9ae33664d20e6df60e78bf51f2d320548cf1
parent044d78e1acb6614f5d79040e490f1fd9bfa45487
[SCSI] scsi_debug: Fix 32-bit overflow in do_device_access causing memory corruption

If I create a scsi_debug device that is larger than 4GB, the multiplication of
(block * scsi_debug_sector_size) can produce a 64-bit value.  Unfortunately,
the compiler sees two 32-bit quantities and performs a 32-bit multiplication,
thus truncating the bits above 2^32.  This causes the wrong memory location to
be read or written.  Change block and rest to be unsigned long long.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/scsi_debug.c