bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes
authorPengcheng Yang <yangpc@wangsu.com>
Tue, 29 Nov 2022 10:40:39 +0000 (18:40 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 1 Dec 2022 00:07:32 +0000 (01:07 +0100)
commita351d6087bf7d3d8440d58d3bf244ec64b89394a
treeb701f761fd3d6e2bcd554587a06343e0817dd05c
parent7a9841ca025275b5b0edfb0b618934abb6ceec15
bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes

When redirecting, we use sk_msg_to_ingress() to get the BPF_F_INGRESS
flag from the msg->flags. If apply_bytes is used and it is larger than
the current data being processed, sk_psock_msg_verdict() will not be
called when sendmsg() is called again. At this time, the msg->flags is 0,
and we lost the BPF_F_INGRESS flag.

So we need to save the BPF_F_INGRESS flag in sk_psock and use it when
redirection.

Fixes: 8934ce2fd081 ("bpf: sockmap redirect ingress support")
Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/1669718441-2654-3-git-send-email-yangpc@wangsu.com
include/linux/skmsg.h
include/net/tcp.h
net/core/skmsg.c
net/ipv4/tcp_bpf.c
net/tls/tls_sw.c