net: thunderx: start phy before starting autonegotiation
authorMian Yousaf Kaukab <ykaukab@suse.de>
Thu, 5 Dec 2019 09:41:16 +0000 (10:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Dec 2019 20:10:40 +0000 (12:10 -0800)
commita350d2e7adbb57181d33e3aa6f0565632747feaa
tree80f4c8825f202d728a7ca658dda4e61e5a317534
parentdf95467b6d2bfce49667ee4b71c67249b01957f7
net: thunderx: start phy before starting autonegotiation

Since commit 2b3e88ea6528 ("net: phy: improve phy state checking")
phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
before calling phy_start_aneg() during probe so that autonegotiation
is initiated.

As phy_start() takes care of calling phy_start_aneg(), drop the explicit
call to phy_start_aneg().

Network fails without this patch on Octeon TX.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/thunder/thunder_bgx.c