dmaengine: altera-msgdma: Correctly handle descriptor callbacks
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 25 Oct 2021 07:54:26 +0000 (09:54 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 28 Oct 2021 17:23:54 +0000 (22:53 +0530)
commita34da7ef9a8c2b89ddb84689562f3d2b48a4e588
tree00f71d23ab07b607c2f3b9eba465b3fae5e25bd4
parentd191a9abc02f1f59bfb3b2349d30cb5534dc0fd9
dmaengine: altera-msgdma: Correctly handle descriptor callbacks

DMA clients can provide one of two types of callbacks. For this reason
dmaengine drivers should not directly invoke `callback`, but always use
dmaengine_desc_callback_invoke(). This makes sure that both types of
callbacks are handled correctly.

The altera-msgdma driver currently doesn't do this and only handles the
`callback` type callback. If the client used the `callback_result` type
callback it will not be called.

Fix this by switching to `dmaengine_desc_callback_valid()` and
`dmaengine_desc_callback_invoke()`.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211025075428.2094-1-lars@metafoo.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/altera-msgdma.c