[SelectionDAG] Check any use of negation result before removal
authorQiu Chaofan <qiucofan@cn.ibm.com>
Thu, 17 Sep 2020 08:00:54 +0000 (16:00 +0800)
committerQiu Chaofan <qiucofan@cn.ibm.com>
Thu, 17 Sep 2020 08:00:54 +0000 (16:00 +0800)
commita2fb5446be960ad164060b3c05fc268f7f72d67a
tree84640d1791c60b43c9b05a8acc8f6e2cf16f0254
parentb05629230e9c7e90a2e70a761f7800afb1a8eefd
[SelectionDAG] Check any use of negation result before removal

2508ef01 fixed a bug about constant removal in negation. But after
sanitizing check I found there's still some issue about it so it's
reverted.

Temporary nodes will be removed if useless in negation. Before the
removal, they'd be checked if any other nodes used it. So the removal
was moved after getNode. However in rare cases the node to be removed is
the same as result of getNode. We missed that and will be fixed by this
patch.

Reviewed By: steven.zhang

Differential Revision: https://reviews.llvm.org/D87614
llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
llvm/test/CodeGen/X86/pr47517.ll [new file with mode: 0644]