iavf: fix potential deadlock on allocation failure
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 10 Jul 2023 20:41:27 +0000 (13:41 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 21 Jul 2023 15:49:37 +0000 (08:49 -0700)
commita2f054c10bef0b54600ec9cb776508443e941343
treeaed0f3215c5c3f3aca7900955d38d73481e8fe60
parent043b1f185fb0f3939b7427f634787706f45411c4
iavf: fix potential deadlock on allocation failure

In iavf_adminq_task(), if kzalloc() fails to allocate the event.msg_buf,
the function will exit without releasing the adapter->crit_lock.

This is unlikely, but if it happens, the next access to that mutex will
deadlock.

Fix this by moving the unlock to the end of the function, and adding a new
label to allow jumping to the unlock portion of the function exit flow.

Fixes: fc2e6b3b132a ("iavf: Rework mutexes for better synchronisation")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c