match.pd: Restrict clz cmp 0 replacement by single_use, PR99142
authorHans-Peter Nilsson <hp@axis.com>
Tue, 16 Feb 2021 21:27:53 +0000 (22:27 +0100)
committerHans-Peter Nilsson <hp@axis.com>
Thu, 18 Feb 2021 12:19:08 +0000 (13:19 +0100)
commita2ef38b1f94dd108046e702ad46dcd8e9b34625e
tree420219e9af3ec6e6a11346524ba24eec8678f761
parenta1541628df83eb690954f426d56d268fb57f1af6
match.pd: Restrict clz cmp 0 replacement by single_use, PR99142

If we're not going to eliminate the clz, it's better for the
comparison to use that result than its input, so we don't
extend the lifetime of the input.  Also, an additional use
of the result is more likely cheaper than a compare of the
input, in particular considering that the clz may have made
available a non-zero condition matching the original use.
The "s" modifier doesn't stop this situation, as the
transformation wouldn't result in "an expression with more
than one operator"; a gating single_use condition on the
result is necessary.

gcc:
PR tree-optimization/99142
* match.pd (clz cmp 0): Gate replacement on single_use of clz result.

gcc/testsuite:
PR tree-optimization/99142
* gcc.dg/tree-ssa/pr99142.c: New test.
gcc/match.pd
gcc/testsuite/gcc.dg/tree-ssa/pr99142.c [new file with mode: 0644]