btrfs: error when COWing block from a root that is being deleted
authorFilipe Manana <fdmanana@suse.com>
Wed, 27 Sep 2023 11:09:22 +0000 (12:09 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 3 Oct 2023 23:04:28 +0000 (01:04 +0200)
commita2caab29884397e583d09be6546259a83ebfbdb1
tree5b390b208d2d753876b15fedb06ebb38898d587a
parent48774f3bf8b4dd3b1a0e155825c9ce48483db14c
btrfs: error when COWing block from a root that is being deleted

At btrfs_cow_block() we check if the block being COWed belongs to a root
that is being deleted and if so we log an error message. However this is
an unexpected case and it indicates a bug somewhere, so we should return
an error and abort the transaction. So change this in the following ways:

1) Abort the transaction with -EUCLEAN, so that if the issue ever happens
   it can easily be noticed;

2) Change the logged message level from error to critical, and change the
   message itself to print the block's logical address and the ID of the
   root;

3) Return -EUCLEAN to the caller;

4) As this is an unexpected scenario, that should never happen, mark the
   check as unlikely, allowing the compiler to potentially generate better
   code.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c