ubi: Fix UAF wear-leveling entry in eraseblk_count_seq_show()
authorZhihao Cheng <chengzhihao1@huawei.com>
Sat, 30 Jul 2022 11:28:37 +0000 (19:28 +0800)
committerRichard Weinberger <richard@nod.at>
Thu, 2 Feb 2023 20:13:50 +0000 (21:13 +0100)
commita240bc5c43130c6aa50831d7caaa02a1d84e1bce
treec4c6475c1b57f85d20de3a1dcdc367e7ede0eae5
parent76f9476ece445a07aeb72df9d896cd563fb5b50f
ubi: Fix UAF wear-leveling entry in eraseblk_count_seq_show()

Wear-leveling entry could be freed in error path, which may be accessed
again in eraseblk_count_seq_show(), for example:

__erase_worker                eraseblk_count_seq_show
                                wl = ubi->lookuptbl[*block_number]
if (wl)
  wl_entry_destroy
    ubi->lookuptbl[e->pnum] = NULL
    kmem_cache_free(ubi_wl_entry_slab, e)
                   erase_count = wl->ec  // UAF!

Wear-leveling entry updating/accessing in ubi->lookuptbl should be
protected by ubi->wl_lock, fix it by adding ubi->wl_lock to serialize
wl entry accessing between wl_entry_destroy() and
eraseblk_count_seq_show().

Fetch a reproducer in [Link].

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216305
Fixes: 7bccd12d27b7e3 ("ubi: Add debugfs file for tracking PEB state")
Fixes: 801c135ce73d5d ("UBI: Unsorted Block Images")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/wl.c