ceph: clean up locking annotation for ceph_get_snap_realm and __lookup_snap_realm
authorJeff Layton <jlayton@kernel.org>
Tue, 1 Jun 2021 13:24:38 +0000 (09:24 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Aug 2021 06:59:18 +0000 (08:59 +0200)
commita23aced54c2c9053a0956fc1a8a6d7c0a0fff96f
tree84d93c5ff66f14c5e8ca208e21d2c5259bc1b804
parentb0efc93271caf3868885a953f7f71c3aced7ba61
ceph: clean up locking annotation for ceph_get_snap_realm and __lookup_snap_realm

commit df2c0cb7f8e8c83e495260ad86df8c5da947f2a7 upstream.

They both say that the snap_rwsem must be held for write, but I don't
see any real reason for it, and it's not currently always called that
way.

The lookup is just walking the rbtree, so holding it for read should be
fine there. The "get" is bumping the refcount and (possibly) removing
it from the empty list. I see no need to hold the snap_rwsem for write
for that.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ceph/snap.c