mtd: spi-nor: Skip erase logic when SPI_NOR_NO_ERASE is set
authorTudor Ambarus <tudor.ambarus@microchip.com>
Mon, 28 Feb 2022 16:33:34 +0000 (18:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jul 2022 14:35:01 +0000 (16:35 +0200)
commita1e69c36de1777cbe2f99cbf7a72070f2c14c6d4
tree046ba2901a4a3339dd25037a9f91f2e32f75674a
parente65d78b12fbc0f4392f9d97dda11e2157a36de42
mtd: spi-nor: Skip erase logic when SPI_NOR_NO_ERASE is set

[ Upstream commit 151c6b49d679872d6fc0b50e0ad96303091694a2 ]

Even if SPI_NOR_NO_ERASE was set, one could still send erase opcodes
to the flash. It is not recommended to send unsupported opcodes to
flashes. Fix the logic and do not set mtd->_erase when SPI_NOR_NO_ERASE
is specified. With this users will not be able to issue erase opcodes to
flashes and instead they will recive an -ENOTSUPP error.

Fixes: b199489d37b2 ("mtd: spi-nor: add the framework for SPI NOR")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220228163334.277730-1-tudor.ambarus@microchip.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/spi-nor/core.c