resolv: Fix file handle leak in __resolv_conf_load [BZ #25429]
authorFlorian Weimer <fweimer@redhat.com>
Tue, 21 Jan 2020 16:11:01 +0000 (17:11 +0100)
committerFlorian Weimer <fweimer@redhat.com>
Fri, 14 Feb 2020 07:13:58 +0000 (08:13 +0100)
commita1a20f029299dc27170912bb9233070c8403444d
tree58caad17547053524bee65848c564ea1c0fc8f81
parent9642b85fd0dfa5731020a3271c08e33e1dc05c85
resolv: Fix file handle leak in __resolv_conf_load [BZ #25429]

res_vinit_1 did not close the stream on errors, only on success.
This change moves closing the stream to __resolv_conf_load, for both
the success and error cases.

Fixes commit 89f187a40fc0ad4e22838526bfe34d73f758b776 ("resolv: Use
getline for configuration file reading in res_vinit_1") and commit
3f853f22c87f0b671c0366eb290919719fa56c0e ("resolv: Lift domain search
list limits [BZ #19569] [BZ #21475]"), where memory allocation was
introduced into res_vinit_1.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
resolv/res_init.c