random: initialize ChaCha20 constants with correct endianness
authorEric Biggers <ebiggers@google.com>
Mon, 22 Mar 2021 05:13:47 +0000 (22:13 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Apr 2021 07:28:12 +0000 (18:28 +1100)
commita181e0fdb2164268274453b5b291589edbb9b22d
tree009f7411d6ede6a6446c09125dfa3acd0a7ea95f
parent30d0f6a956fc74bb2e948398daf3278c6b08c7e9
random: initialize ChaCha20 constants with correct endianness

On big endian CPUs, the ChaCha20-based CRNG is using the wrong
endianness for the ChaCha20 constants.

This doesn't matter cryptographically, but technically it means it's not
ChaCha20 anymore.  Fix it to always use the standard constants.

Cc: linux-crypto@vger.kernel.org
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Jann Horn <jannh@google.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/random.c
include/crypto/chacha.h