Revert "Add new 'preferred_name' attribute."
authorRichard Smith <richard@metafoo.co.uk>
Tue, 8 Dec 2020 08:42:26 +0000 (00:42 -0800)
committerRichard Smith <richard@metafoo.co.uk>
Tue, 8 Dec 2020 08:42:48 +0000 (00:42 -0800)
commita1344779ab019a6bcd29842c1499343e15efbe87
treebe30d6e8ffd88925131b1f19020622838c463311
parent4415678718ad471c84f024e20ce864ae1e79348a
Revert "Add new 'preferred_name' attribute."

This change exposed a pre-existing issue with deserialization cycles
caused by a combination of attributes and template instantiations
violating the deserialization ordering restrictions; see PR48434 for
details.

A previous commit attempted to work around PR48434, but appears to have
only been a partial fix, and fixing this properly seems non-trivial.
Backing out for now to unblock things.

This reverts commit 98f76adf4e941738c0b9fe3b9965fa63603e9c89 and
commit a64c26a47a81b1b44e36d235ff3bc6a74a0bad9f.
16 files changed:
clang/include/clang/AST/TypeProperties.td
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/AST/TypePrinter.cpp
clang/lib/Sema/SemaDeclAttr.cpp
clang/lib/Sema/SemaTemplate.cpp
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/test/PCH/decl-attrs.cpp [deleted file]
clang/test/SemaTemplate/attributes.cpp
clang/utils/TableGen/ClangAttrEmitter.cpp
libcxx/include/__config
libcxx/include/iosfwd
libcxx/include/regex
libcxx/include/string
libcxx/include/string_view