fs/proc/uptime.c: Fix idle time reporting in /proc/uptime
authorJosh Don <joshdon@google.com>
Fri, 27 Aug 2021 16:54:38 +0000 (09:54 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 5 Oct 2021 13:51:35 +0000 (15:51 +0200)
commita130e8fbc7de796eb6e680724d87f4737a26d0ac
tree4adeb41642500b6aca5ddd2b1144a9785e2e591e
parentbc9ffef31bf59819c9fc032178534ff9ed7c4981
fs/proc/uptime.c: Fix idle time reporting in /proc/uptime

/proc/uptime reports idle time by reading the CPUTIME_IDLE field from
the per-cpu kcpustats. However, on NO_HZ systems, idle time is not
continually updated on idle cpus, leading this value to appear
incorrectly small.

/proc/stat performs an accounting update when reading idle time; we
can use the same approach for uptime.

With this patch, /proc/stat and /proc/uptime now agree on idle time.
Additionally, the following shows idle time tick up consistently on an
idle machine:

  (while true; do cat /proc/uptime; sleep 1; done) | awk '{print $2-prev; prev=$2}'

Reported-by: Luigi Rizzo <lrizzo@google.com>
Signed-off-by: Josh Don <joshdon@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lkml.kernel.org/r/20210827165438.3280779-1-joshdon@google.com
fs/proc/stat.c
fs/proc/uptime.c
include/linux/kernel_stat.h