iommu/vt-d: Do deferred attachment in iommu_need_mapping()
authorJoerg Roedel <jroedel@suse.de>
Mon, 17 Feb 2020 16:20:59 +0000 (17:20 +0100)
committerJoerg Roedel <jroedel@suse.de>
Tue, 18 Feb 2020 16:21:51 +0000 (17:21 +0100)
commita11bfde9c77df1fd350ea27169ab921f511bf5d0
tree3e2015c9a9582206e8dae95bed93cebed7b0e66c
parent034d98cc0cdcde2415c6f598fa9125e3eaa02569
iommu/vt-d: Do deferred attachment in iommu_need_mapping()

The attachment of deferred devices needs to happen before the check
whether the device is identity mapped or not. Otherwise the check will
return wrong results, cause warnings boot failures in kdump kernels, like

WARNING: CPU: 0 PID: 318 at ../drivers/iommu/intel-iommu.c:592 domain_get_iommu+0x61/0x70

[...]

 Call Trace:
  __intel_map_single+0x55/0x190
  intel_alloc_coherent+0xac/0x110
  dmam_alloc_attrs+0x50/0xa0
  ahci_port_start+0xfb/0x1f0 [libahci]
  ata_host_start.part.39+0x104/0x1e0 [libata]

With the earlier check the kdump boot succeeds and a crashdump is written.

Fixes: 1ee0186b9a12 ("iommu/vt-d: Refactor find_domain() helper")
Cc: stable@vger.kernel.org # v5.5
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel-iommu.c