scsi: target: core: Fix invalid memory access
authorMaurizio Lombardi <mlombard@redhat.com>
Fri, 7 Apr 2023 13:00:33 +0000 (15:00 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 12 Apr 2023 00:49:43 +0000 (20:49 -0400)
commita0fde512f7030e7fbdd5f0d8d70908d37389aae2
tree1bee7647a4b17b30f047158d562fc596d0ff2111
parentdc70c9615c067dbc34a1af736477f7d2b7f75319
scsi: target: core: Fix invalid memory access

nr_attrs should start counting from zero, otherwise we will end up
dereferencing an invalid memory address.

$ targetcli /loopback create

 general protection fault
 RIP: 0010:configfs_create_file+0x12/0x70
 Call Trace:
  <TASK>
  configfs_attach_item.part.0+0x5f/0x150
  configfs_attach_group.isra.0+0x49/0x120
  configfs_mkdir+0x24f/0x4d0
  vfs_mkdir+0x192/0x240
  do_mkdirat+0x131/0x160
  __x64_sys_mkdir+0x48/0x70
  do_syscall_64+0x5c/0x90

Fixes: 31177b74790c ("scsi: target: core: Add RTPI attribute for target port")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Link: https://lore.kernel.org/r/20230407130033.556644-1-mlombard@redhat.com
Acked-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_fabric_configfs.c