md/raid6: avoid data corruption during recovery of double-degraded RAID6
authorNeilBrown <neilb@suse.de>
Tue, 12 Aug 2014 23:57:07 +0000 (09:57 +1000)
committerZefan Li <lizefan@huawei.com>
Thu, 25 Sep 2014 03:49:11 +0000 (11:49 +0800)
commita0e5b9d2c3cdaf1f980409ec1a84db22abfd6958
treef73a3d79c04ee5b460447e6ba83335d1960d360f
parent77e5657567adc61ab425a070c5a9ec13b20913e8
md/raid6: avoid data corruption during recovery of double-degraded RAID6

commit 9c4bdf697c39805078392d5ddbbba5ae5680e0dd upstream.

During recovery of a double-degraded RAID6 it is possible for
some blocks not to be recovered properly, leading to corruption.

If a write happens to one block in a stripe that would be written to a
missing device, and at the same time that stripe is recovering data
to the other missing device, then that recovered data may not be written.

This patch skips, in the double-degraded case, an optimisation that is
only safe for single-degraded arrays.

Bug was introduced in 2.6.32 and fix is suitable for any kernel since
then.  In an older kernel with separate handle_stripe5() and
handle_stripe6() functions the patch must change handle_stripe6().

Fixes: 6c0069c0ae9659e3a91b68eaed06a5c6c37f45c8
Cc: Yuri Tikhonov <yur@emcraft.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Reported-by: "Manibalan P" <pmanibalan@amiindia.co.in>
Tested-by: "Manibalan P" <pmanibalan@amiindia.co.in>
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1090423
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/md/raid5.c