Fix compile-cplus-types.c build errors
authorSimon Marchi <simon.marchi@ericsson.com>
Thu, 30 Aug 2018 15:09:48 +0000 (11:09 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Thu, 30 Aug 2018 15:09:48 +0000 (11:09 -0400)
commita0dc02a6df86011462293cc11b4e35c0f18effd0
treedf3b4bbbdcb3a1853ce282bdfed1281aa4c8efe8
parent385e5b9039d12d3c2ab25023e827ee9a681c1aad
Fix compile-cplus-types.c build errors

I see these errors when building with clang:

  CXX    compile/compile-cplus-types.o
/home/emaisin/src/binutils-gdb/gdb/compile/compile-cplus-types.c:306:56: error: cannot pass non-trivial object of type 'compile_scope' to variadic function; expected type from format string was 'void *' [-Wnon-pod-varargs]
        fprintf_unfiltered (gdb_stdlog, "leaving scope %p\n", current);
                                                       ~~     ^~~~~~~
/home/emaisin/src/binutils-gdb/gdb/compile/compile-cplus-types.c:1058:13: error: comparison of two values with different enumeration types ('enum_flags<gcc_cp_qualifiers>::enum_type' (aka 'gcc_cp_qualifiers') and 'gcc_cp_ref_qualifiers') [-Werror,-Wenum-compare]
  if (quals != GCC_CP_REF_QUAL_NONE)
      ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~

Fix the first one by using host_address_to_string.

Fix the second one by comparing to 0 instead.  I think the current
comparison simply uses the wrong enum type.  Comparing to 0 seems like
the right thing to do, because we want to check whether any flags are
specified.

gdb/ChangeLog:

* compile/compile-cplus-types.c
(compile_cplus_instance::leave_scope): Take the address of scope
object.
(compile_cplus_instance::convert_qualified_base): Compare quals
to 0.
gdb/ChangeLog
gdb/compile/compile-cplus-types.c