[libc++] type_traits: fix short-circuiting in std::conjunction.
authorAaron Jacobs <jacobsa@google.com>
Fri, 21 Oct 2022 11:08:30 +0000 (13:08 +0200)
committerNikolas Klauser <nikolasklauser@berlin.de>
Fri, 21 Oct 2022 11:09:16 +0000 (13:09 +0200)
commita0549ee2a39013c6ff75b86cda9d4ccfadb0ab88
treeec9a6123519e7cf733d87ead9272db3e128f9750
parent14a5b9cdaefee281dbd3814cf0ae04d728a90a30
[libc++] type_traits: fix short-circuiting in std::conjunction.

Replace the two-level implementation with a simpler one that directly subclasses
the predicates, avoiding the instantiation of the template to get the `type`
member in a situation where we should short-circuit. This prevents incorrect
diagnostics when the instantiated predicate contains a static assertion.

Add a test case that reproduced the previous problem. The existing test case
involving `HasNoValue` didn't catch the problem because `HasNoValue` was in the
final position. The bug comes up when the predicate that shouldn't be
instantiated is after the short-circuit position but there is more to follow,
because then `__conjunction_impl<False, BadPredicate, ...>` instantiates
`__conjunction_impl<BadPredicate, ...>` (in order to obtain its `type` member),
which in turn instantiates `BadPredicate` in order to obtain its `value` member.

In contrast the new implementation doesn't recurse in instantiation any further
than it needs to, because it doesn't require particular members of the recursive
case.

I've also updated the test cases for `std::disjunction` to match,
although it doesn't have the same particular bug (its implementation is
quite different).

Fixes #58490.

Reviewed By: #libc, ldionne, philnik

Spies: philnik, ldionne, libcxx-commits

Differential Revision: https://reviews.llvm.org/D136318
libcxx/include/__type_traits/conjunction.h
libcxx/test/std/utilities/meta/meta.logical/conjunction.compile.pass.cpp
libcxx/test/std/utilities/meta/meta.logical/disjunction.compile.pass.cpp